Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): switch to GH action for testing CI build image #5342

Merged
merged 8 commits into from
Oct 13, 2023
Merged

feat(ci): switch to GH action for testing CI build image #5342

merged 8 commits into from
Oct 13, 2023

Conversation

hainenber
Copy link
Contributor

PR Description

From what I've checked, drone.io's configuration no longer supports triggering builds based on changed paths. We should switch to GitHub Actions for this feature.

There should be no risks as the migrated parts are only for building throw-away test images, no pushing to any remote registry.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated

@hainenber hainenber requested a review from a team as a code owner October 1, 2023 07:04
@tpaschalis
Copy link
Member

Thanks for opening that PR! Even though Drone itself does not support paths for its trigger syntax, there are third-party extensions that can be used for this.

For this reason, and since I think it has been working fine, I think it's best we continue using Drone for the build-image CI step. WDYT?

@hainenber
Copy link
Contributor Author

Yes, I noticed there's a 3rd-party extension that would help our issue atm but as far as I'm aware, this would require the infrastructure complexity of hosting said extension as well as secrets handling/storage to connect Drone endpoint with it.

If we migrate to GH Actions, it'd be a hassle-(free) :)

@rfratto
Copy link
Member

rfratto commented Oct 11, 2023

For security reasons, we're currently unable to use Drone on PRs, and can only do it after merge. Given that, I think it makes sense to test the CI build images using GitHub Actions, so that we have validations earlier.

cc @tpaschalis WDYT?

@tpaschalis
Copy link
Member

cc @tpaschalis WDYT?

Yeah, I'm okay with it (sorry missed your previous message @hainenber)

rfratto
rfratto approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hainenber! I'm going to clean this PR up a little bit (to remove your test changes and resign the Drone config) and then get this merged. Nice work!

rfratto
rfratto reviewed Oct 13, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@rfratto rfratto merged commit e4eed15 into grafana:main Oct 13, 2023
7 checks passed
@hainenber hainenber deleted the switch-testing-build-image-to-gh-action branch October 14, 2023 06:49
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hainenber @tpaschalis @rfratto